-
-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This fixes #133 by implementing the proposal therein, which changes webidl2js's overall architecture. Now, the code generated by webidl2js installs new constructors and prototypes on a given global object, instead of exporting classes directly. See the updated README for more usage details, but a quick summary of the changes: * The generated files for interfaces now export an install(globalObject) function, instead of an interface property. * The create() and createImpl() exports now take a global object as their new first parameter, making the signature (globalObject, constructorArgs, privateData). * Similarly, impl class constructors now also take a global object as their first argument, given them the same signature. * The expose export was removed, as it was not generally used. We may introduce better support for exposure in the future, probably as an option to the install() export. * [WebIDL2JSFactory] was removed, as it is no longer necessary: all interfaces are now per-global object.
- Loading branch information
Showing
6 changed files
with
3,666 additions
and
3,323 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.