-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(interface): Use default export for implementation #141
refactor(interface): Use default export for implementation #141
Conversation
add(x, y) { | ||
return x + y; | ||
} | ||
}; | ||
``` | ||
|
||
> Note: It's also possible to use ES2015 module default export syntax: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true; jsdom only operates on CommonJS modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, you do need to transpile ES2015 modules to be able to use them in Node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That is not a supported scenario, so please remove it.
@@ -74,6 +74,52 @@ const namedSetNew = Symbol("named property set new"); | |||
const namedSetExisting = Symbol("named property set existing"); | |||
const namedDelete = Symbol("named property delete"); | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not interested in this addition. Please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which? The JSDoc or the entire utils.importStar(…)
function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The importStar function itself.
d239363
to
3dc3ff3
Compare
Fixes #59
This changes the implementation class syntax to allow CommonJS and ES2015 style default exports:
TODO:
importStar(…)
helper.