Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XDG_CACHE_HOME from start.sh sudo call #1522

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Remove XDG_CACHE_HOME from start.sh sudo call #1522

merged 1 commit into from
Nov 10, 2021

Conversation

mathbunnyru
Copy link
Member

Fix: #1518

consideRatio
consideRatio approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! XDG_CACHE_HOME is passed via --preserve-env without disruption as PATH and PYTHONPATH would experience.

@mathbunnyru mathbunnyru merged commit 8dfdbfd into jupyter:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove XDG_CACHE_HOME from start.sh sudo call
2 participants
@mathbunnyru @consideRatio