Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused *args in KernelManager's __init__ #986

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Unused *args in KernelManager's __init__ #986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e355cc6
Unused *args in KernelManager `__init__`
Carreau Oct 23, 2023
933d3bf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions jupyter_client/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import sys
import typing as t
import uuid
import warnings
from asyncio.futures import Future
from concurrent.futures import Future as CFuture
from contextlib import contextmanager
Expand Down Expand Up @@ -106,6 +107,15 @@ class KernelManager(ConnectionFileMixin):

def __init__(self, *args: t.Any, **kwargs: t.Any) -> None:
"""Initialize a kernel manager."""
if args:
warnings.warn(
"Passing positional only arguments to "
"`KernelManager.__init__` is deprecated since jupyter_client"
" 8.6, and will become an error on future versions. Positional "
" arguments have been ignored since jupyter_client 7.0",
DeprecationWarning,
stacklevel=2,
)
self._owns_kernel = kwargs.pop("owns_kernel", True)
super().__init__(**kwargs)
self._shutdown_status = _ShutdownStatus.Unset
Expand Down
Loading