Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore usage of flake8 and add to CI #316

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Restore usage of flake8 and add to CI #316

wants to merge 7 commits into from

Conversation

danyeaw
Copy link
Contributor

@danyeaw danyeaw commented Jan 31, 2025 •
edited
Loading

In #315, I accidently removed the flake8 configuration that was in the setup.cfg. This PR restores it and makes some additional improvements:

  • Fixes issue detected by flake8
  • Add a pre-commit hook to make it easier to run on each commit
  • Add additional pre-commit hooks to fix trailing whitespace and end of files
  • Add a step to CI to lint the changes

It would also be great to eventually move to using Ruff like jupyter/notebook, but that would be a much larger cleanup effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyeaw @krassowski