-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add changelog for 2.0.0 (beta.1) #2528
docs: add changelog for 2.0.0 (beta.1) #2528
Conversation
2771be0
to
66bf824
Compare
👋 Hi, I'm currently on 1.2.0 and am just trying to figure out when 2.0.0 will be released. Are there any concrete plans to release 2.0.0 imminently? Is there a better issue or place I can track progress? |
Needs to be doneHere are things I'd like to see done before we agree to merge a changelog and cut a release that I can quickly name from the top of my head.
|
be1d734
to
2479908
Compare
ba277eb
to
603be3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 1 .....
628d511
to
b28534f
Compare
@manics ❤️ 🎉 thank you!!!!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2
@manics ❤️ 🎉 🚀 thanks for pushing onwards!!! Feel free to push commits directly if you want btw! |
If we want to begin pre-testing the 2.x release while waiting for the last items related to changelogs, where would we find that chart? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great! It seems to me in good shape for a 2.0 beta. What coverage is still missing before we can cut a beta?
docs/source/changelog.md
Outdated
#### TODO: link out to relevant informational posts | ||
|
||
TODO: Write a discourse forum post about the following and highlight that via | ||
the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the order for this? Write the post now, then link here, or make a first beta, then write the post, then add link here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I think getting the beta out first with a short Discourse post linking to the changelog and upgrade guide makes sense and will help speed things up. Save the longer discourse post (and maybe something on the official Jupyter blog) for the final release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### TODO: link out to relevant informational posts
TODO: Write a discourse forum post about the following and highlight that via
the changelog.
- 100+ user-placeholder pods -> node-placeholder pods
- autohttps acme acquisition issues on GKE mitigation
(notable-dependencies-200)=
I think it is quite crucial to be aware of that user placeholder pods shouldn't be over 100 or similar, and that there are currently some issues on GKE with slow setup of networking - which causes failures in the autohttps system. But, lets get this out there now instead and hope that we manage to communicate that sometime else instead.
In e8cc8a1 I removed this TODO entry.
@consideRatio I've merged in main (to bring in the new |
@consideRatio I think I've added all the missing PRs so this should be up to date now. I've changed the version to |
I've rebased and squashed all commits into one here, in case you want to force push it to this PR: |
Iterative improvements on the changelog 2.0.0 entry Co-authored-by: Simon Li <[email protected]> docs: use sphinx references instead of hardcoded links docs: small changelog updates [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci docs: added descriptions of breaking changes Co-authored-by: Simon Li <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Port fixes from changelog to new upgrade guide Remove breaking/upgrade guide from changelog, link to new guide Add 2.0.0 notable deps anchor to changelog Co-authored-by: Min RK <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Include example of args in singleuser.cmd Add description of changes to changelog Co-authored-by: Simon Li <[email protected]> 2.0.0-beta.1, with warnings Update 2.0.0 changelog with more PRs Update 2.0.0 dependencies table Remove some backticks which somehow crept in
e37493f
to
d01f3d6
Compare
At risk of delaying this further, the next release of JupyterHub requires another DB upgrade, so maybe we should wait? |
To me, this seems a good reason not to delay. Users can get an awesome new version now without having to upgrade the db. Unless I'm misunderstanding. |
JupyterHub 2 already requires a DB upgrade. |
Yup, JupyterHub 2 has a big, disruptive DB upgrade requiring everything to shutdown and restart. JupyterHub 3 has a db upgrade that z2jh users running the default sqlite shouldn't even notice. I'm not necessarily opposed to pulling in JupyterHub 3, but if we do that, I'd like to try to focus on reviewing hub 3.0 release PRs. As far as I'm concerned, everything's ready to go but the changelog and I could make a 3.0 beta today: jupyterhub/jupyterhub#3994 . But I don't want to self-merge too much over there. |
What do folks think about testing jupyterhub/chartpress#150 during the 2.0 prerelease cycle? (note: does not need to be picked up before making the first 2.0 beta) |
@manics @minrk @sgibson91 - should we go for a release with this? I've updated the PR entries etc so far. The changelog entry can be reviewed in https://zero-to-jupyterhub--2528.org.readthedocs.build/en/2528/changelog.html. |
Let's go for a release! |
Updated and ready for review. We will use JupyterHub 3.0.0b1 for z2jh 2.0.0-beta.1