feat: clamp fractional digits

kartva · Aug 21, 2024 · af238e0 · af238e0
1 parent a572e81
commit af238e0
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/components/experimental/src/duration/format.rs b/components/experimental/src/duration/format.rs
@@ -780,4 +780,15 @@ mod tests {
             Err(DurationFormatterOptionsError::PreviousFractional)
         );
     }
+
+    #[test]
+    fn test_fractional_digit_clamping() {
+        let options = DurationFormatterOptions {
+            fractional_digits: FractionalDigits::Fixed(10),
+            ..Default::default()
+        };
+
+        let options = ValidatedDurationFormatterOptions::validate(options).unwrap();
+        assert_eq!(options.fractional_digits, FractionalDigits::Fixed(9));
+    }
 }
diff --git a/components/experimental/src/duration/options.rs b/components/experimental/src/duration/options.rs
@@ -68,7 +68,8 @@ pub enum FractionalDigits {
     #[default]
     ShowAll,
     /// Use the given number of fractional digits.
-    /// Rounded to zero if necessary.
+    /// This value is clamped to the range 0..=9.
+    /// Fractional digits are rounded to zero if necessary.
     Fixed(u8),
 }
 

diff --git a/components/experimental/src/duration/validated_options.rs b/components/experimental/src/duration/validated_options.rs
@@ -187,6 +187,12 @@ impl ValidatedDurationFormatterOptions {
             prev_style = *style;
         }
 
+        // section 1.2.1
+        // 27. Set durationFormat.[[FractionalDigits]] to ? GetNumberOption(options, "fractionalDigits", 0, 9, undefined).
+        if let FractionalDigits::Fixed(i) = builder.fractional_digits {
+            builder.fractional_digits = FractionalDigits::Fixed(i.clamp(0, 9));
+        }
+
         Ok(builder.try_into().unwrap())
     }