Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump knative-operator version to 1.17.2 #268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

metacoma
Copy link
Contributor

@metacoma metacoma commented Feb 5, 2025

fix for #267

1. Please confirm that you have read the document before PR submitted

2. Contact Information(Optional)

If it is convenient, please provide your contact information so we can reach you when processing the PR:

@liangyuanpeng
Copy link
Contributor

I think you need to follow https://github.com/kcl-lang/modules/pull/268/checks?check_run_id=36737722599 to sign commit

chore: bump knative-eventing and knative-serving to 1.17.0 version
fix: remove Knative Serving and Eventing crds and related kcl code
feat: add knative-operator crds

Signed-off-by: Sergey Ryabin <[email protected]>
Signed-off-by: Sergey Ryabin <[email protected]>
edition = "*"
version = "0.1.2"
description = "`knative` is the knative spec definition"
version = "0.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---edition = "*"
---description = "`knative` is the knative spec definition"

It's not need to remove,right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants