Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding import with multiple files, type system and various schemas #24

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

Vishalk91-4
Copy link
Contributor

@Vishalk91-4 Vishalk91-4 commented Jul 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
re #2

2. What is the scope of this PR (e.g. component or file name):

grammar.js
import.txt
schema.txt
type.txt

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
  • Fixing code for import statement with multiple files
  • Added Type Guards
  • Added Schema index signature attribute alias
  • Added schema Kwargs in Arguments
  • Added Test Cases for the above

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: Vishal <[email protected]>
@Vishalk91-4 Vishalk91-4 marked this pull request as ready for review July 25, 2024 04:08
@Vishalk91-4 Vishalk91-4 changed the title [WIP] Adding import with multiple files, type system and block literals [WIP] Adding import with multiple files, type system and various schemas Jul 25, 2024
@Vishalk91-4 Vishalk91-4 changed the title [WIP] Adding import with multiple files, type system and various schemas Adding import with multiple files, type system and various schemas Jul 25, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a32ed22 into kcl-lang:main Jul 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants