Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract dns_parser.rs into its own crate mdns-parser #284

Merged
merged 7 commits into from
Dec 21, 2024
Merged

extract dns_parser.rs into its own crate mdns-parser #284

merged 7 commits into from
Dec 21, 2024

Conversation

keepsimple1
Copy link
Owner

@keepsimple1 keepsimple1 commented Dec 15, 2024 •
edited
Loading

This patch is trying to resolve issue #282 . At the high level:

  • dns_parser.rs is extracted into its own crate mdns-parser (not published on crates.io yet)
  • the new crate is kept in this same repo to keep things easier to manage (and the patch diff easier to track).
  • mdns-sd crate will depend on the new crate mdns-parser (inside the repo)

@keepsimple1 keepsimple1 mentioned this pull request Dec 15, 2024
Closed
rasheedsulayman
rasheedsulayman approved these changes Dec 15, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/dns_cache.rs Show resolved Hide resolved
@keepsimple1 keepsimple1 merged commit b1795c9 into main Dec 21, 2024
3 checks passed
@keepsimple1 keepsimple1 deleted the extract-dns-parser branch December 21, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasheedsulayman rasheedsulayman rasheedsulayman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keepsimple1 @rasheedsulayman