Change version of helm chart to locust-service version from keptn version #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botchk
requested review from
adriangonciarz,
christian-kreuzberger-dtx and
jetzlstorfer
as code owners
…tn version Signed-off-by: Dominik Augustin <[email protected]>
botchk
force-pushed
the
fix/helm-chart-version
branch
from
1a3839c to
b30ad37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the version of the locust-service in the helm chart instead of the keptn version. Currently in deploy/service.yaml the
app.kubernetes.io/versiongets set to0.1.5, while for the helm chart the version fromchart.yamlis used, resulting inapp.kubernetes.io/version: 0.8.7.The version is also used in the uniform registration and displayed in the bridge and probably should be the same for each deployment method.