Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[programmer_dvorak] New keyboard #3335

Merged
merged 7 commits into from
Feb 17, 2025

Conversation

Caliph3ubaidUrRe7man
Copy link
Contributor

No description provided.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@LornaSIL
Copy link
Contributor

I'll be taking a few days to focus on other work. I'll try to check this in a few days.

@LornaSIL
Copy link
Contributor

In general this looks to be in good shape. There is one significant issue I think you will want to fix. The word "programmar" is misspelled and should be "programmer" (at least I don't think this was an intentional spelling). That means in all the filenames and foldername it needs correcting as well as all the keyboard names in the files.

One other thing. When I keyboard does not contain a mobile layout, the .js file should not be included in the files in the .kps file.

@LornaSIL
Copy link
Contributor

Thanks. Can you remove the folder and files for programmar_dvorak?

@LornaSIL LornaSIL changed the title programmar dvorak [programmer_dvorak] New keyboard Feb 17, 2025
Remove redundant targets
Remove references to graphics since we are using `div`.
Copy link
Contributor Author

@Caliph3ubaidUrRe7man Caliph3ubaidUrRe7man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the point of the keyboard if its only on the web?

@LornaSIL
Copy link
Contributor

LornaSIL commented Feb 17, 2025

whats the point of the keyboard if its only on the web?

The desktop target encompasses "Windows Linux and macOS". So, listing Desktop, Windows, Linux, macOS is redundant.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit 22fabb0 into keymanapp:master Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants