-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[programmer_dvorak] New keyboard #3335
Conversation
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
I'll be taking a few days to focus on other work. I'll try to check this in a few days. |
In general this looks to be in good shape. There is one significant issue I think you will want to fix. The word "programmar" is misspelled and should be "programmer" (at least I don't think this was an intentional spelling). That means in all the filenames and foldername it needs correcting as well as all the keyboard names in the files. One other thing. When I keyboard does not contain a mobile layout, the |
Thanks. Can you remove the folder and files for |
Remove redundant targets
Remove references to graphics since we are using `div`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the point of the keyboard if its only on the web?
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.