Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation improvements for macOS #1084

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Jan 19, 2025

Fixes: #1083
Based on the PR from: #1079

FYA: jarrodmoldrich

keyboard_nav.mov

Note

The black keyboard is not part of the application, just meant to showcase which buttons were pressed, while navigating around.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 35.78%. Comparing base (d2c9f14) to head (5efa74b).

Files with missing lines Patch % Lines
Views/SearchResults.swift 0.00% 43 Missing ⚠️
Views/ViewModifiers/Focusable.swift 0.00% 27 Missing ⚠️
Views/ViewModifiers/MoveCommand.swift 0.00% 17 Missing ⚠️
Views/ViewModifiers/KeyPressHandler.swift 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1084       +/-   ##
===========================================
+ Coverage   23.92%   35.78%   +11.86%     
===========================================
  Files         124      132        +8     
  Lines        7018     7631      +613     
===========================================
+ Hits         1679     2731     +1052     
+ Misses       5339     4900      -439     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve keyboard navigation for macOS
3 participants