Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add fibonacci documentation #217

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: add fibonacci documentation #217

wants to merge 3 commits into from

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Jan 17, 2025

No description provided.

zmalatrax
zmalatrax reviewed Jan 17, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
zmalatrax
zmalatrax reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fib19.bf works well with visualizing the memory, where the hello_kakarot.bf is good for its speediness and proper use of the Brainfuck I/O

We can keep fib(19) in this PR and add the hello_kakarot in another one if we want two examples

README.md Outdated
Comment on lines 92 to 96
Or if you built from source and previously generated the proof of the 19th Fibonacci number:

```shell
./target/release/brainfuck_prover verify hello_kakarot.json
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to change the sentence while changing the program to be verified

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmalatrax zmalatrax zmalatrax left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eikix @zmalatrax