Merge pull request #13 from koculu/12-enhancement-reduce-seek-count-o… #19
koculuAnnotations
11 warnings
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build:
src/ZoneTree.FullTextSearch/QueryLanguage/UnexpectedTokenException.cs#L6
Add the following constructor to UnexpectedTokenException: public UnexpectedTokenException() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1032)
|
|
build:
src/ZoneTree.FullTextSearch/QueryLanguage/UnexpectedTokenException.cs#L6
Add the following constructor to UnexpectedTokenException: public UnexpectedTokenException(string message, Exception innerException) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1032)
|
|
build:
src/ZoneTree.FullTextSearch/Search/QueryNode.cs#L19
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
|
build:
src/ZoneTree.FullTextSearch/Search/QueryNode.cs#L24
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
|
build:
src/ZoneTree.FullTextSearch/Model/NGramToken4.cs#L11
NGramToken4 should override Equals (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
|
|
build:
src/ZoneTree.FullTextSearch/Model/NGramToken4.cs#L11
NGramToken4 should override the equality (==) and inequality (!=) operators (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
|
|
build:
src/ZoneTree.FullTextSearch/Tokenizer/WordTokenizer.cs#L83
In externally visible method 'void WordTokenizer.AddStopWords(string[] stopWords)', validate parameter 'stopWords' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
build:
src/ZoneTree.FullTextSearch/Storage/RecordTable.cs#L114
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
|
|
build:
src/ZoneTree.FullTextSearch/Search/QueryNode.cs#L62
'NodeType == QueryNodeType.Or' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build:
src/ZoneTree.FullTextSearch/Search/HashedSearchQueryFactory.cs#L26
In externally visible method 'QueryNode<ulong> HashedSearchQueryFactory.FromStringQueryNode(QueryNode<string> node, IHashCodeGenerator hashCodeGenerator, IWordTokenizer wordTokenizer)', validate parameter 'node' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|