-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ipos): filebase IPFS worker #316
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
core packages of the propposed stack are not yet compatible with cloudlflare worker's environment do we change env or go with another alternative cc @vikiival @preschian mainly ref: |
Hey, We will use filebase. |
services/ipos/src/routes/pinning.ts
Outdated
ContentType: type, | ||
}) | ||
|
||
await c.env.BUCKET.put(cid, new Blob([content], { type })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use wait until so it's non blocking op
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@vikiival @preschian pls create a new worker called thanks |
@SocketSecurity ignore [email protected] |
Tested, works as charm |
@SocketSecurity ignore npm/[email protected] |
Context
add new
ipos
workerenvs
bucket: https://docs.filebase.com/getting-started/ipfs-getting-started-guide#how-to-create-an-ipfs-bucket
s3: https://docs.filebase.com/getting-started/s3-api-getting-started-guide#access-keys
Ref
PR Type
Screenshots