Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make registered repository sync frequency configurable #4076

Merged
merged 1 commit into from
Nov 2, 2023
Merged

make registered repository sync frequency configurable #4076

merged 1 commit into from
Nov 2, 2023

Conversation

himanshu19w
Copy link
Contributor

No description provided.

@himanshu19w himanshu19w marked this pull request as draft October 27, 2023 14:41
@himanshu19w himanshu19w marked this pull request as ready for review October 27, 2023 14:41
@himanshu19w himanshu19w reopened this Oct 27, 2023
johnbelamaric
johnbelamaric requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. Two things:

  • Sign the DCA
  • Change it to a time.Duration and allow the config to be passed in as a duration

porch/pkg/apiserver/apiserver.go Outdated Show resolved Hide resolved
@johnbelamaric
Copy link
Contributor

And add some tests...

@himanshu19w himanshu19w force-pushed the sync-repo-frequency branch 2 times, most recently from fd50941 to 7650f6f Compare October 29, 2023 16:37
@himanshu19w
Copy link
Contributor Author

Did the required changes (Signed DCA and passed the config as time.Duration).

Can you please point me to where the required tests should be written? I am not able to find the test setup where I can embed tests related to this change.

@himanshu19w
Copy link
Contributor Author

Resolved the comments.

@himanshu19w
Copy link
Contributor Author

I have fixed the unit test (license was required at the start of newly added file).

I dont know why e2e tests are failing. They also failed for some of the previous PRs.

mortent
mortent reviewed Nov 1, 2023
View reviewed changes
porch/Makefile Show resolved Hide resolved
@johnbelamaric johnbelamaric merged commit a88f1fc into kptdev:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric approved these changes

@mortent mortent mortent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himanshu19w @johnbelamaric @mortent