New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test: e2e: make managed suite more robust to errors with Eventually() #5215

Merged

k8s-ci-robot merged 1 commit into kubernetes-sigs:main from damdo:fix-eventually

Jan 31, 2025

+89 −45

Member

damdo commented Nov 13, 2024

What type of PR is this?
/kind flake

What this PR does / why we need it:
make managed suite more robust to errors with Eventually()

Special notes for your reviewer:
Trying to address issues like the ones seen here: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5211/pull-cluster-api-provider-aws-e2e-eks/1856371404925046784

NONE

k8s-ci-robot added release-note-none kind/flake cncf-cla: yes labels

k8s-ci-robot requested review from dlipovetsky and nrb

November 13, 2024 14:32

k8s-ci-robot added needs-priority size/L labels

Member Author

damdo commented Nov 13, 2024

/assign @richardcase @nrb

k8s-ci-robot assigned nrb and richardcase

Member Author

damdo commented Nov 13, 2024

/test ?

Contributor

k8s-ci-robot commented Nov 13, 2024

@damdo: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-build-docker
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-build-docker
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Member Author

damdo commented Nov 13, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 13, 2024

Failed is unrelated (due to AWS CloudFormation stack)

/test pull-cluster-api-provider-aws-e2e-eks

damdo force-pushed the fix-eventually branch from f860b49 to acd3ed3 Compare

November 13, 2024 19:16

Member Author

damdo commented Nov 13, 2024

/test pull-cluster-api-provider-aws-e2e-eks

2 similar comments

Member Author

damdo commented Nov 13, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-test

damdo force-pushed the fix-eventually branch from acd3ed3 to 7d6b8b6 Compare

November 14, 2024 11:13

Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

1 similar comment

Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

damdo mentioned this pull request

✨ Add the support for capacity blocks #5211

Merged

5 tasks

Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

2 similar comments

Member Author

damdo commented Nov 15, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 15, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 15, 2024

AWS Cloud formation stack timed out

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 15, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 15, 2024

@richardcase do you have any idea on why waiting for addons fails so often?

Member Author

damdo commented Nov 20, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member Author

damdo commented Nov 21, 2024

/test pull-cluster-api-provider-aws-e2e-eks

nrb reviewed

View reviewed changes

test/e2e/data/e2e_eks_conf.yaml Outdated Show resolved Hide resolved

Member Author

damdo commented Nov 22, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Member

Ankitasw commented Nov 26, 2024

@damdo since eventually failed for addons test in few runs, do you think we should increase the timeout from 2 minutes? Or is there any other issue?

damdo force-pushed the fix-eventually branch from cd5bd86 to 697e555 Compare

November 26, 2024 14:09

Member Author

damdo commented Nov 26, 2024

/test pull-cluster-api-provider-aws-e2e-eks

1 similar comment

Member Author

damdo commented Nov 26, 2024

/test pull-cluster-api-provider-aws-e2e-eks

nrb reviewed

View reviewed changes

test/e2e/suites/managed/addon.go Outdated Show resolved Hide resolved

Member Author

damdo commented Nov 26, 2024

It still fails at Should've eventually succeeded creating an AWS CloudFormation stack

Member Author

damdo commented Nov 26, 2024

/test pull-cluster-api-provider-aws-e2e-eks

1 similar comment

Member Author

damdo commented Nov 26, 2024

/test pull-cluster-api-provider-aws-e2e-eks

nrb mentioned this pull request

EKS e2e tests permanently failing #5237

Closed

damdo force-pushed the fix-eventually branch from 697e555 to f8e8806 Compare

January 27, 2025 11:23

Member Author

damdo commented Jan 27, 2025

/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e

Member Author

damdo commented Jan 27, 2025

This one is green, if you want to add your labels

/assing @nrb @richardcase

nrb reviewed

View reviewed changes

test/e2e/suites/managed/addon.go Outdated Show resolved Hide resolved


          test: e2e: make managed suite more robust to errors with Eventually()

6cc4c6c

damdo force-pushed the fix-eventually branch from f8e8806 to 6cc4c6c Compare

January 28, 2025 09:31

nrb reviewed

View reviewed changes

test/e2e/suites/managed/helpers.go Show resolved Hide resolved

Contributor

nrb commented Jan 28, 2025

/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e

Member Author

damdo commented Jan 29, 2025

@nrb @AndiDog @Ankitasw tests are green if you want to stamp your approval. Thanks!

Contributor

nrb commented Jan 30, 2025

/approved
/lgtm

k8s-ci-robot added the lgtm label

Member Author

damdo commented Jan 31, 2025

@nrb approve didn't stick, there is a typo in the command.

damdo requested a review from nrb

January 31, 2025 09:09

Member

richardcase commented Jan 31, 2025

/approve

Contributor

k8s-ci-robot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the approved label

k8s-ci-robot merged commit 0d61f5b into kubernetes-sigs:main

19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cncf-cla: yes kind/flake lgtm needs-priority release-note-none size/L