Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v1.3.0-alpha.0 of ray #4354

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v1.3.0-alpha.0 of ray on behalf of @kevin85421.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Jan 21, 2025

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/ray.yaml is not a straightforward version bump: version should have metadata ("alpha.0"), only no pre-release versions are auto-approved
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krew-release-bot
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2025
@MortalHappiness
Copy link
Contributor

MortalHappiness commented Jan 22, 2025

Need to discuss with @kevin85421, the maintainer of the KubeRay project, about whether release candidates should be included in the krew-index repository. Please DO NOT MERGE this PR for now. Thank you very much!

@kevin85421
Copy link

@ahmetb would you mind closing this PR? We plan not to release kubectl plugin for the alpha relase. Thanks!

@ahmetb
Copy link
Member

ahmetb commented Jan 22, 2025

@kevin85421 consider updating your GitHub action to exclude the unwanted tags.

@ahmetb ahmetb closed this Jan 22, 2025
@MortalHappiness
Copy link
Contributor

MortalHappiness commented Jan 22, 2025

@ahmetb We are working on it in ray-project/kuberay#2798. Sorry for the inconvenience.

@ahmetb
Copy link
Member

ahmetb commented Jan 22, 2025

Manual approach may be a worse idea than just fixing to a better regexp. :)

@kevin85421
Copy link

@ahmetb thanks. We will revisit this when we have a more concrete release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants