Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v1.4.0 of get-all #4375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v1.4.0 of get-all on behalf of @Kumm-Kai.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Jan 29, 2025

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/get-all.yaml is not a straightforward version bump: change on line 4 does not seem like a version bump: [- platforms:]
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krew-release-bot
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2025
@Kumm-Kai
Copy link

Kumm-Kai commented Jan 29, 2025

Because corneliusweig/ketall is unmaintained, we've decided to maintain it in our fork stackitcloud/kubectl-get-all. Discussion about forking: corneliusweig/ketall#185

In the https://krew.sigs.k8s.io/docs/developer-guide/ docs, I could not find any information about how forking should be handled. Should we choose a different name, suffix the current one with fork, or what would be the best solution?

@ahmetb
Copy link
Member

ahmetb commented Jan 29, 2025

You need @corneliusweig's blessing ideally. Are you having trouble getting a hold of him?

@Kumm-Kai
Copy link

You need @corneliusweig's blessing ideally. Are you having trouble getting a hold of him?

We did not yet try to contact him, but without digging too deep, I was unable to find a proper email address or other ways to contact him.
Additionally, his last activity on GitHub is from February 2024... :(

@ahmetb
Copy link
Member

ahmetb commented Feb 3, 2025

@Kumm-Kai you may find him on slack.k8s.io. He's actually one of the maintainers of Krew. :)

@Kumm-Kai
Copy link

Kumm-Kai commented Feb 4, 2025

@Kumm-Kai you may find him on slack.k8s.io. He's actually one of the maintainers of Krew. :)

I gave it a shot, although his last message in the slack is from 2021 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants