Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #57 from viniciusarcanjo/dpid_not_found
return 404 status code when dpid is not found
- Loading branch information
cb3af0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code contains a typo: "reponse".
Also, it could return 404 in the hypothetical case of multiple switches being returned (eg.:
[valid_switch1, valid_switch2, None]
). The code would be more correct ifNone
instances were filtered out (usingfilter(None, switches)
, for example).cb3af0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdiogenes nice catch. :) Can you or @viniciusarcanjo send a fix, sorry, but I already accepted.
cb3af0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIxed the typo directly in master: 35c56d7
cb3af0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hdiogenes. I missed this notification. My bad.