Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation cleanup #310

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Documentation cleanup #310

merged 9 commits into from
Nov 14, 2023

Conversation

ceriottm
Copy link
Contributor

@ceriottm ceriottm commented Oct 25, 2023

New PR to address the documentation issues that were left open by a prematurely merged PR.
@rosecers could you please use this to Fix #295 ? perhaps a UWMadison student could do this?

Also Fixes #295 broken link in the load/save form

Also Fixes #259 - at least it should

@rosecers
Copy link
Collaborator

Hi @ceriottm! In general it looks good, although I'll note that the standalone link gives me this:

Screen Shot 2023-11-13 at 8 59 54 AM

@saswatnayak1998 is also going to give a look this morning, then should be almost ready

@ceriottm
Copy link
Contributor Author

Hi @ceriottm! In general it looks good, although I'll note that the standalone link gives me this:

Screen Shot 2023-11-13 at 8 59 54 AM @saswatnayak1998 is also going to give a look this morning, then should be almost ready

ok this is due to the browser ignoring the download attribute when opening a link from a different source.
It works when the documentation is deployed on chemiscope.org and not locally. I'll merge now, feel free to open another PR if you want to further polish the docs

@ceriottm ceriottm merged commit 6fba5b2 into main Nov 14, 2023
9 checks passed
@ceriottm ceriottm deleted the docs/update-2023 branch November 14, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better documentation needed for write_input(settings = ...) Lots of stuff out of date in the documentation
3 participants