Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chemiscope.metatensor_featurizer #357

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chemiscope.metatensor_featurizer #357

merged 1 commit into from
Sep 26, 2024

Conversation

sofiia-chorna
Copy link
Collaborator

@sofiia-chorna sofiia-chorna commented Aug 13, 2024

The function that takes a metatensor model and returns a function to be used in chemiscope.explore as a featurizer.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
@sofiia-chorna sofiia-chorna changed the title torchscript_featurizer chemiscope.metatensor_featurizer Aug 13, 2024
@sofiia-chorna sofiia-chorna deleted the torchscript_featurizer branch August 13, 2024 15:08
@sofiia-chorna sofiia-chorna restored the torchscript_featurizer branch August 13, 2024 15:09
@sofiia-chorna sofiia-chorna reopened this Aug 13, 2024
@sofiia-chorna
Copy link
Collaborator Author

The idea was to rename the branch but remain the PR (unsuccessfully ^^), finally I will keep this one for convenience of review

python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/chemiscope/explore.py Outdated Show resolved Hide resolved
python/examples/6-explore.ipynb Outdated Show resolved Hide resolved
@sofiia-chorna sofiia-chorna marked this pull request as ready for review September 17, 2024 20:45
@Luthaf Luthaf force-pushed the torchscript_featurizer branch from 0f9d202 to 3f31d13 Compare September 25, 2024 11:35
@Luthaf
Copy link
Contributor

Luthaf commented Sep 25, 2024

I rebased and updated the example a bit to show the simple case of using a pre-trained model first. This should be good to go for me, @ceriottm do you want to give this a quick look?

This allows taking a metatensor model that compute "features"
and use it in chemiscope.explore
@Luthaf Luthaf merged commit d423e68 into main Sep 26, 2024
6 checks passed
@Luthaf Luthaf deleted the torchscript_featurizer branch September 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants