refactor: use type halfvec instead of vector in PGVector #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by deploy action📦 Preview Image: |
I-Info
force-pushed
the
feat/halfvec-v2
branch
from
126fc5b to
5219e7d
Compare
c121914yu
reviewed
Feb 14, 2025
|
|
||
| let rowsUpdated; | ||
| do { | ||
| rowsUpdated = await PgClient.query(` |
There was a problem hiding this comment.
需要加 try catch。
后面无需等待了，必要性不大。
There was a problem hiding this comment.
感觉不是很必要？最外层已经有一个try catch了。如果update出现异常还可以再次执行脚本。
c121914yu
reviewed
Feb 14, 2025
I-Info
changed the title
c121914yu
reviewed
Feb 14, 2025
|
|
||
| let rowsUpdated; | ||
| do { | ||
| rowsUpdated = await PgClient.query(` |
There was a problem hiding this comment.
while里应该加 try catch 吧？不然失败一个，不就全终止了
There was a problem hiding this comment.
全终止了还能再运行脚本的吧，应该不是太影响。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.