Merge pull request #8647 from ehuelsmann/cleanup/undefined-value-warning

Fix warning about undefined values in Batch.pm
ledgersmb · Feb 13, 2025 · 4f5daf2 · 4f5daf2
2 parents 89e2ef1 + f80db4a
commit 4f5daf2
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/old/lib/LedgerSMB/Batch.pm b/old/lib/LedgerSMB/Batch.pm
@@ -256,12 +256,14 @@ Returns the batch C<approved_on> date (being the current database date).
 sub post {
     my ($self) = @_;
 
-    $log->info("Deleting batch $self->{id} of class $self->{batch_class_id}");
-    if (not (defined $self->{batch_class_id}
-             and ($self->{batch_class_id} == BC_PAYMENT
-                  or $self->{batch_class_id} == BC_PAYMENT_REVERSAL
-                  or $self->{batch_class_id} == BC_RECEIPT
-                  or $self->{batch_class_id} == BC_RECEIPT_REVERSAL))) {
+    my $id = $self->{id} // '';
+    my $batch_class_id = $self->{batch_class_id} // '';
+    $log->info("Deleting batch $id of class $batch_class_id");
+    if (not ($batch_class_id ne ''
+             and ($batch_class_id == BC_PAYMENT
+                  or $batch_class_id == BC_PAYMENT_REVERSAL
+                  or $batch_class_id == BC_RECEIPT
+                  or $batch_class_id == BC_RECEIPT_REVERSAL))) {
         # payments and receipts (and reversals) are part of a transaction
         # which may already have been approved, meaning that 'batch-approve'
         # isn't available...