-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include pod UID and container name as optional trace labels #3483
Conversation
you've been clippy'ed 📎 🙀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the note about clippy lints above, this looks like a good PR to me. this should be a nice improvement to our traces!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3483 +/- ##
==========================================
- Coverage 67.68% 66.59% -1.09%
==========================================
Files 332 390 +58
Lines 15158 18340 +3182
==========================================
+ Hits 10259 12214 +1955
- Misses 4899 6126 +1227
... and 172 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
d76fa98
to
89d0203
Compare
This allows us to include arbitrary values from the k8s downward API beyond just the pod labels that are included in the trace attributes file. See linkerd/linkerd2#13544 for the corresponding control plane change. Signed-off-by: Scott Fleener <[email protected]>
It's useful to include these fields in the trace span attributes to help correlate traffic within a cluster.
This propagates these labels through the trace initialization, similar to how we handle the service name (and other labels that last for the entire pod lifetime).
See linkerd/linkerd2#13501 for the corresponding control plane change.