ci: Add an additional NIC for test purposes #762
Conversation
spetrosi
force-pushed
the
tft-add-2-nics
branch
from
2968a18 to
878207d
Compare
spetrosi
force-pushed
the
tft-add-2-nics
branch
2 times, most recently
from
94a3e52 to
bf0c783
Compare
spetrosi
force-pushed
the
tft-add-2-nics
branch
from
bf0c783 to
b477173
Compare
.github/workflows/tft.yml
Outdated
| @@ -180,7 +180,7 @@ jobs: | |||
| tf_scope: private | |||
| api_key: ${{ secrets.TF_API_KEY_RH }} | |||
| update_pull_request_status: false | |||
| tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB" }' | |||
| tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB", "network": [{"type": "eth"},{"type": "eth"}] }' | |||
There was a problem hiding this comment.
what is the NIC name or how can we tell from the config ?
There was a problem hiding this comment.
When I tested it interfaces were eth0 and eth1.
tmt docs list 5 parameters for network: type, device-name, device, vendor-name, vendor, driver. Maybe it may help to provide some of these to make setup more specific.
spetrosi
force-pushed
the
tft-add-2-nics
branch
from
b477173 to
980fb58
Compare
| @@ -180,7 +180,7 @@ jobs: | |||
| tf_scope: private | |||
| api_key: ${{ secrets.TF_API_KEY_RH }} | |||
| update_pull_request_status: false | |||
| tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB" }' | |||
| tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB", "network": [{"type": "eth", "device-name": "eth0"}, {"type": "eth", "device-name": "eth1"}] }' | |||
There was a problem hiding this comment.
@liangwen12year does this work?
There was a problem hiding this comment.
We've tested it with Wen in TF and it seems to be working. Will see how TF action likes this syntax.
There was a problem hiding this comment.
I pair-programmed with @spetrosi on a testing farm machine using the following command, and it works as expected.
ip a
nmcli c
nmcli d
ethtool -P eth0
cat /sys/class/net/eth0/address
ethtool -P eth1
cat /sys/class/net/eth1/address
| @@ -180,7 +180,7 @@ jobs: | |||
| tf_scope: private | |||
| api_key: ${{ secrets.TF_API_KEY_RH }} | |||
| update_pull_request_status: false | |||
| tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB" }' | |||
| tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB", "network": [{"type": "eth", "device-name": "eth0"}, {"type": "eth", "device-name": "eth1"}] }' | |||
There was a problem hiding this comment.
The commit message is a bit confusing, it is not adding two NICs , you only added 1 additional NIC, eth0 is still the default device for bridging the ssh connection between the control node and the managed host. Can you change the commit message to ci: Configure two NICs for testing purposes ?
Signed-off-by: Sergei Petrosian <[email protected]>
spetrosi
force-pushed
the
tft-add-2-nics
branch
from
980fb58 to
0b6a266
Compare
spetrosi
changed the title
No description provided.