ci: support ansible-lint and ansible-test 2.16

Fix yamllint issue with markdownlint config

Add cleanup for tests_include_vars_from_parent.yml

Use correct shebang for shell scripts

Ignore sanity[cannot-ignore] for ansible-lint due to python2 ipaddress
library requirement for `unicode_literals`

Signed-off-by: Rich Megginson <[email protected]>

.ansible-lint

@@ -15,6 +15,7 @@ kinds:
 skip_list:
   - fqcn-builtins
   - var-naming[no-role-prefix]
+  - sanity[cannot-ignore]
 exclude_paths:
   - tests/roles/
   - .github/

.markdownlint.yaml

@@ -1,3 +1,4 @@
+---
 # Default state for all rules
 default: true
 

.sanity-ansible-ignore-2.10.txt

@@ -1,3 +1,2 @@
 plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
 tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip
-lsr_role2coll_extra_script-vpn shebang!skip

.sanity-ansible-ignore-2.11.txt

@@ -1,3 +1,2 @@
 plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
 tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip
-lsr_role2coll_extra_script-vpn shebang!skip

.sanity-ansible-ignore-2.12.txt

@@ -1,3 +1,2 @@
 plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
 tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip
-lsr_role2coll_extra_script-vpn shebang!skip

.sanity-ansible-ignore-2.13.txt

@@ -1,3 +1,2 @@
 plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
 tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip
-lsr_role2coll_extra_script-vpn shebang!skip

.sanity-ansible-ignore-2.14.txt

@@ -1,3 +1,2 @@
 plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
 tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip
-lsr_role2coll_extra_script-vpn shebang!skip

.sanity-ansible-ignore-2.15.txt

@@ -1,3 +1,2 @@
 plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
 tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip
-lsr_role2coll_extra_script-vpn shebang!skip

.sanity-ansible-ignore-2.16.txt

@@ -0,0 +1,2 @@
+plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
+tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip

.sanity-ansible-ignore-2.9.txt

@@ -1,3 +1,2 @@
 plugins/filter/vpn_ipaddr.py no-unicode-literals!skip
 tests/vpn/unit/test_vpn_ipaddr.py no-unicode-literals!skip
-lsr_role2coll_extra_script-vpn shebang!skip

lsr_role2coll_extra_script

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 if [ -n "${LSR_DEBUG:-}" ]; then

tests/roles/caller/tasks/main.yml

@@ -1,8 +1,10 @@
 ---
 # tasks file for caller
 
-- include_role:
+- name: Include role
+  include_role:
     name: "{{ roletoinclude }}"
 
-- assert:
+- name: Test variable override
+  assert:
     that: not __caller_override

tests/tests_include_vars_from_parent.yml

@@ -1,5 +1,5 @@
 ---
-- name: Test role variable override
+- name: Test role include variable override
   hosts: all
   gather_facts: true
   tasks:
@@ -38,9 +38,18 @@
         varfiles: "{{ [facts['distribution']] | product(separators) |
           map('join') | product(versions) | map('join') | list +
           [facts['distribution'], facts['os_family']] }}"
+      register: __varfiles_created
 
     - name: Import role
       import_role:
         name: caller
       vars:
         roletoinclude: linux-system-roles.vpn
+
+    - name: Cleanup
+      file:
+        path: "{{ item.dest }}"
+        state: absent
+      loop: "{{ __varfiles_created.results }}"
+      delegate_to: localhost
+      when: inventory_hostname == ansible_play_hosts_all[0]