Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kino.Render.Any.to_livebook/1 #491

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Use Kino.Render.Any.to_livebook/1 #491

merged 2 commits into from
Feb 13, 2025

Conversation

josevalim
Copy link
Contributor

Otherwise folks may copy and paste the contents
of this file, accidentally using Kino.Output's private
API. Relying on Kino.Render.Any is ok because that's
a public fallback.

Other options to consider: use Kino.Text |> Kino.Render.to_livebook,
although that's more verbose.

Otherwise folks may copy and paste the contents
of this file, accidentally using Kino.Output's private
API. Relying on Kino.Render.Any is ok because that's
a public fallback.
lib/kino/render.ex Outdated Show resolved Hide resolved
@jonatanklosko jonatanklosko merged commit 3401ec1 into main Feb 13, 2025
1 check passed
@jonatanklosko jonatanklosko deleted the jv-no-kino-output branch February 13, 2025 06:28
@jonatanklosko
Copy link
Member

Good call :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants