[libclc] Move mad to the CLC library #123607
Open
+2,014
−1,840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mix builtin, which is implemented as a wrapper around mad, is left as an OpenCL-layer wrapper of __clc_mad. I don't know if it's worth having a specific CLC version of mix. All targets build __clc_mad -- even SPIR-V targets -- since it compiles to the optimal llvm.fmuladd intrinsic. There is no change to the bytecode generated for non-SPIR-V targets. The changes to the other CLC files/functions are moving uses of mad to __clc_mad, and reformatting. There is an additional instance of trunc becoming __clc_trunc, which was missed before.
arsenm
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All targets build
__clc_mad-- even SPIR-V targets -- since it compiles to the optimalllvm.fmuladdintrinsic. There is no change to the bytecode generated for non-SPIR-V targets.The
mixbuiltin, which is implemented as a wrapper aroundmad, is left as an OpenCL-layer wrapper of__clc_mad. I don't know if it's worth having a specific CLC version ofmix.The changes to the other CLC files/functions are moving uses of
madto__clc_mad, and reformatting. There is an additional instance oftruncbecoming__clc_trunc, which was missed before.