-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEOMESA-3447 FSDS - Support allow-list for attribute partition scheme #3271
GEOMESA-3447 FSDS - Support allow-list for attribute partition scheme #3271
Conversation
dlgundry
commented
Jan 31, 2025
•
edited
Loading
edited
- Added the ability to provided a comma separated list of allowed paths to AttributeScheme
- Allows AttributeScheme to be configured to only partition specific pre-defined allowed paths in FSDS
...n/src/main/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala
Outdated
Show resolved
Hide resolved
...n/src/main/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala
Outdated
Show resolved
Hide resolved
...n/src/main/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala
Outdated
Show resolved
Hide resolved
seems like we should also update |
78d00ea
to
918b990
Compare
I think I have captured your comment with the latest commit |
looks good, i think there's just a little bit of inconsistency in when we're dealing with type-encoded values and plan values. i'll try to capture that in another comment in a minute. |
So for the attribute index, we run values through a lexicoder, which maps from a normal value to a sorted stringified value. i.e. if you're dealing with ints, 0 maps to something like 80000000 so that negative values sort correctly. there are 2 methods, |
@dlgundry you'll also need to sign the Eclipse CLA as outlined here: https://github.com/locationtech/geomesa/blob/main/CONTRIBUTING.md#eclipse-contributor-agreement |
...n/src/main/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala
Outdated
Show resolved
Hide resolved
{"fundingSource": "41203", "team": "FED.ICGSA.APPS.FUSION.ARCH", "fshGit": "885a7c43", "fshDocker": "sha256:a8bfeb6e"}
d3d0d3e
to
4e628f7
Compare
...n/src/main/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala
Outdated
Show resolved
Hide resolved
generally, don't force-push, that makes it easier to track changes - then i'll squash down and clean up the messages on merge. |
…in/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala Co-authored-by: Emilio <[email protected]>
...c/test/scala/org/locationtech/geomesa/fs/storage/common/partitions/PartitionSchemeTest.scala
Show resolved
Hide resolved
{"fundingSource": "41203", "team": "FED.ICGSA.APPS.FUSION.ARCH", "fshGit": "a4f7446b", "fshDocker": "sha256:054bce20"}
...n/src/main/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala
Show resolved
Hide resolved
@fdfea any more comments? |
…in/scala/org/locationtech/geomesa/fs/storage/common/partitions/AttributeScheme.scala Co-authored-by: Emilio <[email protected]>
{"fundingSource": "41203", "team": "FED.ICGSA.APPS.FUSION.ARCH", "fshGit": "a4f7446b", "fshDocker": "sha256:054bce20"}
lgtm 🚀 |
{"fundingSource": "41203", "team": "FED.ICGSA.APPS.FUSION.ARCH", "fshGit": "a4f7446b", "fshDocker": "sha256:054bce20"}