Skip to content

Commit

Permalink
Some fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Malte Schütze committed Jan 25, 2015
1 parent e35a45d commit 4d356b8
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 9 deletions.
4 changes: 2 additions & 2 deletions rest/src/main/java/net/boreeas/riotapi/rest/ApiHandler.java
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ public ShardStatus getShardStatus(Shard shard) {
* @return The match details.
* @see <a href="https://developer.riotgames.com/api/methods#!/806/2848">Official API Documentation</a>
*/
public Match getMatch(long matchId) {
public MatchDetail getMatch(long matchId) {
return getMatch(matchId, true);
}

Expand All @@ -1061,7 +1061,7 @@ public Match getMatch(long matchId) {
* @return The match details.
* @see <a href="https://developer.riotgames.com/api/methods#!/806/2848">Official API Documentation</a>
*/
public Match getMatch(long matchId, boolean includeTimeline) {
public MatchDetail getMatch(long matchId, boolean includeTimeline) {
WebTarget tgt = matchInfoTarget.path("" + matchId).queryParam("includeTimeline", includeTimeline);
return gson.fromJson($(tgt), MatchDetail.class);
}
Expand Down
3 changes: 0 additions & 3 deletions rest/src/main/java/net/boreeas/riotapi/rest/Match.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import net.boreeas.riotapi.com.riotgames.platform.game.GameMode;
import net.boreeas.riotapi.com.riotgames.platform.game.GameType;
import net.boreeas.riotapi.com.riotgames.platform.game.QueueType;
import net.boreeas.riotapi.com.riotgames.team.dto.Team;
import net.boreeas.riotapi.constants.Season;

import java.util.ArrayList;
Expand All @@ -44,7 +43,5 @@ public class Match {
private GameType matchType;
private QueueType queueType;
private String platformId;
private List<Team> teams = new ArrayList<>();
private MatchTimeline timeline;
private Season season;
}
2 changes: 0 additions & 2 deletions rest/src/main/java/net/boreeas/riotapi/rest/MatchSummary.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,11 @@
package net.boreeas.riotapi.rest;

import lombok.Getter;
import net.boreeas.riotapi.constants.Season;

/**
* This class is no longer needed, but for compatibility reasons can't be removed
* @author Malte Schütze
*/
@Getter
public class MatchSummary extends Match {
private Season season;
}
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ public Future<ShardStatus> getShardStatus(Shard shard) {
* @return The match details.
* @see <a href="https://developer.riotgames.com/api/methods#!/806/2848">Official API Documentation</a>
*/
public Future<Match> getMatch(long matchId) {
public Future<MatchDetail> getMatch(long matchId) {
return new ApiFuture<>(() -> handler.getMatch(matchId));
}

Expand All @@ -914,7 +914,7 @@ public Future<Match> getMatch(long matchId) {
* @return The match details.
* @see <a href="https://developer.riotgames.com/api/methods#!/806/2848">Official API Documentation</a>
*/
public Future<Match> getMatch(long matchId, boolean includeTimeline) {
public Future<MatchDetail> getMatch(long matchId, boolean includeTimeline) {
return new ApiFuture<>(() -> handler.getMatch(matchId, includeTimeline));
}
// </editor-fold>
Expand Down

0 comments on commit 4d356b8

Please sign in to comment.