lxqt-config-monitor: Change dialog button from QToolButton to QPushButton #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the "Settings" dialog button to a QPushButton. This simplifies the Designer UI file and fixes text/icon alignment (for example on Fusion.)
isf63
changed the title
|
liblxqt uses QDialogButtonBox which itself uses QPushButton. Re:
QToolButton has different (and in my opinion, worse) styling than QPushButton.
|
I'm afraid there's nothing to fix. It's like saying, "Don't use tabs because they look ugly with Fusion." |
|
QToolButton is styled differently in most Qt styles. Logically dialog buttons should be consistently QPushButton as that is what liblxqt uses. EDIT: And in Kvantum as well. |
|
IMO, in no way should a code avoid using a widget because of how it's drawn by this or that Qt style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the "Settings" dialog button to a QPushButton. This simplifies the Designer UI file and fixes text/icon alignment (for example on Fusion.)