Using std::make_unique C++17 and add const ref for readability #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palinek
requested changes
Aug 19, 2024
CMakeLists.txt
Outdated
| @@ -12,6 +12,8 @@ set(CMAKE_AUTOMOC ON) | |||
| set(CMAKE_AUTOUIC ON) | |||
| set(CMAKE_INCLUDE_CURRENT_DIR ON) | |||
|
|
|||
| set(CMAKE_CXX_STANDARD 17) | |||
There was a problem hiding this comment.
The c++ standard is driven by lxqt-build-tools LXQTCompilerSettings.cmake module. Now I see, it was bumped to v17 a while ago. Please, remove this line.
sudo.cpp
Outdated
| const char ** param_arg = params.get() + 1; | ||
|
|
||
| std::string program = backendName().toLocal8Bit().data(); | ||
|
|
There was a problem hiding this comment.
Please, avoid trailing spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tsujan