Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put tabbar right above the folder-view. #316

Closed
wants to merge 1 commit into from
Closed

Put tabbar right above the folder-view. #316

wants to merge 1 commit into from

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Feb 27, 2016

Just a simple layout change. The previous position of tabs, above the left pane, seemed a little counterintuitive.

Just a simple layout change. The previous position of tabs, above the left pane, seemed a little counterintuitive.
@PCMan
Copy link
Member

PCMan commented Feb 29, 2016

No, this is done by design.

  1. This can contain more tabs in the same window width.
  2. Firefox has similar layout.
  3. We've been using this in old gtk+ version of pcmanfm for years and no users complain of that.

@PCMan
Copy link
Member

PCMan commented Feb 29, 2016

However, if this is optional and is turned off by default, I'm happy to include it.

@pmattern
Copy link
Contributor

Besides I didn't open an issue yet something I'd love to see is being able to make the choice between Directory Tree and Places view not per window as right now but per tab. This is something I figure would be very useful, in particular as long as #144 isn't addressed. But if selecting the view mode per tab should ever get implemented the current placement of tabs would still make more sense.
Regarding the current behaviour to have the same kind of view in all tabs of a window I agree that the layout proposed by this PR is definitely better.
So all in all I agree with @PCMan that this new feature should somehow be made optional.

@tsujan
Copy link
Member Author

tsujan commented Feb 29, 2016

@PCMan
This change of layout doesn't seem so important to me. I used Qt styles with centered tabs since I came to LXQT. Once I applied a style with left-aligned tabs, I found the current layout somehow odd and also aesthetically unappealing. However:

This can contain more tabs in the same window width.

Most screens are wide enough nowadays. Moreover, tab scroll buttons and "tab tear" automatically appear when needed (I've never seen them with PCManFM although I usually open multiple tabs).

Firefox has similar layout.

It could be also said that Dolphin has a layout similar to this PR.

We've been using this in old gtk+ version of pcmanfm

That's just a matter of habit. Perhaps, my point is so too ;)

@PCMan
Copy link
Member

PCMan commented Feb 29, 2016

@tsujan Would you please make this feature optional?

@tsujan
Copy link
Member Author

tsujan commented Feb 29, 2016

@PCMan Sure!

@tsujan
Copy link
Member Author

tsujan commented Mar 6, 2016

@PCMan
Done at #323 !
Please close this PR if you prefer #323 over it.

@PCMan
Copy link
Member

PCMan commented Mar 10, 2016

Yes, let's fix this there.

@PCMan PCMan closed this Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants