Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item name font_size_formats #888

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MartinVanVan
Copy link

Description (*)

The item name that is defined in the adminhtml/di.xml for the Magento\PageBuilder\Model\Wysiwyg\DefaultConfigProvider is wrong. The solution is to change the item name from fontsize_formats to font_size_formats.
So the font size dropdown in the tinymce toolbar is showing the defined options.

Bug

Fixed Issues (if relevant)

  1. Wrong config key fontsize_formats in di.xml results in missing font size option in page builder #886: Wrong config key fontsize_formats in di.xml results in missing font size option in page builder

Manual testing scenarios (*)

  1. Apply patch ACSD-62755
  2. create or edit a page/block
  3. insert or select a text element
  4. toolbar should show all defined font size options in dropdown
image

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant