fix: React.forwardRef() error in rainbow-button.tsx #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Issue: * Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()? **Solution: ** - Add React.forwardRef and pass the ref to the button element. **Changes: ** - Modify the RainbowButton component to use React.forwardRef. - Accept the ref parameter and pass it to the <button> element.
|
@kulterryan is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
kulterryan
changed the title
kulterryan
changed the title
|
Hey @kulterryan thanks for catching this! We’re already aware of this situation and are working on improving all the buttons, including the rainbow button. Closing this PR in favor of #492 Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
Solution
Changes: