Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keep_latest #56

Merged
merged 2 commits into from
May 17, 2024
Merged

Add keep_latest #56

merged 2 commits into from
May 17, 2024

Conversation

beerinho
Copy link
Collaborator

This PR adds the keep_latest task type.
Copying from ember-concurrency, keep_latest will create a queue of subsequent tasks but only run the most recent addition when the current instance has completed

@beerinho beerinho requested a review from paoloricciuti April 26, 2024 14:30
@beerinho beerinho self-assigned this Apr 26, 2024
@beerinho beerinho added the enhancement New feature or request label Apr 26, 2024
Copy link
Collaborator

@paoloricciuti paoloricciuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me except for the missing max. As expressed in #54 i feel like we should use camel for public facing api (as much as i don't like it). Let's thinker about this.

src/lib/handlers/keep_latest.ts Outdated Show resolved Hide resolved
src/lib/handlers/keep_latest.ts Outdated Show resolved Hide resolved
@beerinho beerinho force-pushed the dbeer/keep-latest branch 2 times, most recently from b6d0058 to ecf9a73 Compare May 17, 2024 11:32
@beerinho beerinho force-pushed the dbeer/keep-latest branch from ecf9a73 to 3b8fbbe Compare May 17, 2024 11:39
@beerinho beerinho mentioned this pull request May 17, 2024
@paoloricciuti paoloricciuti merged commit f52f17c into main May 17, 2024
2 checks passed
@paoloricciuti paoloricciuti deleted the dbeer/keep-latest branch May 17, 2024 14:28
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants