feat: better async transform (yield replace await) #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So after today discussion i couldn't bother not trying this.
I've passed back the value from the awaited next if the function is a generator allowing for a syntax like this
this still sucks in TS so we should still recommend users to do this
BUT
this allow us to change the async transform to transform this
into this
the advantage of this is that if the task is aborted while the promise still hasn't resolved after it resolve we don't assign to value which could be much better if value was a reactive variable in svelte.
In this PR i've also updated the vite plugin to apply this better transform (you can see how the transform change in the generated test files)