Add TaskInstance and derive last
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paoloricciuti, when you have a chance, please could you have a look at this and confirm you agree with the direction. I also wasn't sure where the best place for the tests were. On one hand it would be useful to have each task type tested here, but on the other hand it is more specifically testing the I'll also be gone for the next 2 Fridays so please feel free to take this over if you have capacity |
paoloricciuti
approved these changes
Jun 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: still need to add tests and docs
This PR moves the task specific details into the
TaskInstanceinterface and uses that to update theTaskderived stateCloses #82
Closes #85
Closes #86
Closes #83