Minting UX #8
Merged
Minting UX #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lykimq
force-pushed
the
quyen@staging
branch
3 times, most recently
from
c93ca4d to
211f80d
Compare
lykimq
force-pushed
the
quyen@staging
branch
2 times, most recently
from
5e57e4c to
306caac
Compare
aguillon
requested changes
Jan 20, 2024
There was a problem hiding this comment.
Hey that's great, thank you! Can you just please remove the Makefile and use the npm related instructions in the README instead? And add the animation to the Stash button as well please.
Also, please remove the text-align: center; that I added for the main component? I don't know what I was thinking but yikes.
lykimq
force-pushed
the
quyen@staging
branch
2 times, most recently
from
216a15d to
79d6d32
Compare
|
Seems good for me ! |
|
I add the stashing progress bar at this commit |
|
Looks good thanks, let's test on staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
index.ts*d.ts, *.jsin.gitignore