-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Ability to use custom method for get requests #555
base: master
Are you sure you want to change the base?
[RFR] Ability to use custom method for get requests #555
Conversation
Could you document the change in the docs? (cf 54f50e8) |
Good to me. Waiting for marmelab/admin-config#24 PR to be merged. |
Can you just rebase on master to ensure all tests are green? We fixed them yesterday. :) |
Your PR absolutely doesn't work. Did you even test it? The restangular code doesn't make sense. Please, test your code before submitting it (e.g. by setting the retrieveMethod to 'GET' to make sure it doesn't break anything), I just spent half an hour trying to make this work. |
Apologies for wasting your time on this one! I have since fixed said issues but the tests were failing due to some dependency issues, which I have fixed with this PR: #585 |
Did you test with a simple |
…-method-for-get-one-and-get-list Conflicts: build/ng-admin-only.min.js build/ng-admin.min.js
Yes I did and it works :) but the method needs to be lowercase! |
Is this now fully implemented and works now? I would also really need that feature to force POST method on the getList()... Thanks much much and best regards; |
It seems that |
I have just submitted a pull request for your admin-config module for adding a custom method to get requests. I have changed getOne and getList functions to allow for the custom methods