feat: add question selection #50
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Questions to QuestionFilterKind, if the filterKind is Questions, the selections will be an array of title-slug, first we need to find the questions by slug, the rest are remaining the same, basically a copy and paste from the exisiting "Topics" logic, potentially should be refactored. Added question router and two endpoints, one for search a specific question by search term, the other one will randomly return 10 questions for the user to pick. Fixes: marwanhawari#4
Added a new Tab called Questions, added search functionality which is server side search, each time the server will return the most relevant 5 results. If the user chooses Questions over Topics, then the question title slug will be saved into `RoomSetting.questionFilter.selections`. Added questions type to QuestionFilter in order to display the questions again when setting modal is reopened. The user can max select 4 questions, which is the same as current behaviour. Fixes: marwanhawari#4
github-actions
bot
added
extension
jakecastelli
changed the title
jakecastelli
commented
Jul 7, 2023
| } | ||
| ); | ||
| if (!response.ok) { | ||
| throw new Error("Failed to fetch current players"); |
There was a problem hiding this comment.
fix(jake): need to change this, probably refactor the whole queryFn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server changes:
Added
Questionsto QuestionFilterKind, if thefilterKindisQuestions, theselectionswill be an array of title-slug. First we need to find the questionsby title slug, the rest are remaining the same, basically a copy and paste from the
exisiting "Topics" logic, potentially can be refactored.
Added question router and two endpoints, one for search a specific question by
search term, the other one will randomly return 20 questions for the user to
pick.
Client (extension) changes:
Added a new Tab called Questions, added search functionality which is server
side search, each time the server will return the most relevant 5 results.
If the user chooses Questions over Topics, then the question title slug will be
saved into
RoomSetting.questionFilter.selections.Added questions type to QuestionFilter in order to display the questions again
when setting modal is reopened.
The user can max select 4 questions, which is the same as current behaviour.