Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine pilot tabs #1980

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Conversation

karidyas
Copy link
Contributor

@karidyas karidyas commented Apr 26, 2022

Description

Combined Dossier and Narrative Profile into one tab, and Tactical Profile and Hangar into one tab to group concerns and cut down on necessary clicks.
Dossier is quite short but has some necessary functions in it like changing name and callsign. Hangar is equally short, so they were both good candidates.

Requesting pull into Dev as might need performance testing. It's fine on my machine (at least no worse than Live) but may have an impact on mobile and I don't know how to test that. If that wouldn't be possible I can change the location.

Type of change

  • Refactor (change that improves existing design or functionality)

@karidyas karidyas force-pushed the combine_pilot_tabs branch from 6ccd18a to a778346 Compare April 26, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants