-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine pilot tabs #1980
Open
karidyas
wants to merge
21
commits into
massif-press:dev
Choose a base branch
from
karidyas:combine_pilot_tabs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Combine pilot tabs #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed pilot button to go to tactical profile, commented out unused or
Issue massif-press#1847 - fix GetOrganized active mode
refactor(mech nav): pilot button to tactical profile, removed options
…Codes fix(pilot): roster remote refresh, error handling
Removed sections that aren't used any more due to being merged into
Updated reference to sheet in pilot management routes, deleted files
points to new location in tactical.
karidyas
force-pushed
the
combine_pilot_tabs
branch
from
April 26, 2022 08:46
6ccd18a
to
a778346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combined Dossier and Narrative Profile into one tab, and Tactical Profile and Hangar into one tab to group concerns and cut down on necessary clicks.
Dossier is quite short but has some necessary functions in it like changing name and callsign. Hangar is equally short, so they were both good candidates.
Requesting pull into Dev as might need performance testing. It's fine on my machine (at least no worse than Live) but may have an impact on mobile and I don't know how to test that. If that wouldn't be possible I can change the location.
Type of change