review comments

materialsproject · Jan 7, 2025 · 2d68ed2 · 2d68ed2
1 parent 49eb43f
commit 2d68ed2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/emmet-core/emmet/core/tasks.py b/emmet-core/emmet/core/tasks.py
@@ -147,10 +147,10 @@ def from_vasp_calc_doc(
         OutputDoc
             The calculation output summary.
         """
-        if calc_doc.output.ionic_steps is not None:
+        if calc_doc.output.ionic_steps:
             forces = calc_doc.output.ionic_steps[-1].forces
             stress = calc_doc.output.ionic_steps[-1].stress
-        elif trajectory is not None:
+        elif trajectory:
             ionic_steps = trajectory.frame_properties
             forces = ionic_steps[-1]["forces"]
             stress = ionic_steps[-1]["stress"]
@@ -983,7 +983,7 @@ def _get_max_force(calc_doc: Calculation) -> Optional[float]:
     """Get max force acting on atoms from a calculation document."""
     if calc_doc.output.ionic_steps:
         forces: Optional[Union[np.ndarray, List]] = None
-        if calc_doc.output.ionic_steps is not None:
+        if calc_doc.output.ionic_steps:
             forces = calc_doc.output.ionic_steps[-1].forces
 
         structure = calc_doc.output.structure