Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to JMolNN if open babel is not installed when generating MoleculeMetadata #1150

Closed
wants to merge 2 commits into from

Conversation

Andrew-S-Rosen
Copy link
Member

Closes #1149.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Fall back to JMolNN if open babel is not installed Fall back to JMolNN if open babel is not installed when generating MoleculeMetadata Nov 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.57%. Comparing base (a705a61) to head (f2b6450).

Files with missing lines Patch % Lines
emmet-core/emmet/core/utils.py 33.33% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a705a61) and HEAD (f2b6450). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a705a61) HEAD (f2b6450)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1150       +/-   ##
===========================================
- Coverage   90.42%   72.57%   -17.86%     
===========================================
  Files         147       77       -70     
  Lines       14448     5105     -9343     
===========================================
- Hits        13065     3705     -9360     
- Misses       1383     1400       +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Make OpenBabel optional for molecule metadata
2 participants