Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflow to support PEP 625 for source distribution file names #1152

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Dec 3, 2024

As reported in #1148, our source distribution file names are not compliant with PEP 625, (e.g., emmet-api-0.84.3rc4.tar.gz vs emmet_api-0.84.3rc4.tar.gz)

Bumping the minimum versions for the build packages rectifies this.

Support for PEP 625 was added to setuptools in 69.4.0, however that version was yanked, along with a few other version up through 72.0.0, so installing build packages with --upgrade explicitly should get us where we want to be.

Uploads to TestPyPi now show the correct name normalization: test-emmet-core

Bumping the python version as well while we're here.

@tsmathis tsmathis added github_actions Pull requests that update Github_actions code pkg Package health and distribution related stuff labels Dec 3, 2024
@tsmathis tsmathis linked an issue Dec 3, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (faf1592) to head (e8e383f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1152   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files         147      147           
  Lines       14455    14455           
=======================================
  Hits        13070    13070           
  Misses       1385     1385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis merged commit 9fb8e9e into main Dec 3, 2024
8 checks passed
@tsmathis tsmathis deleted the sdist_name_normalization branch December 3, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code pkg Package health and distribution related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: PEP 625 Compatibility
2 participants