Update how summary magnetic ordering is determined for electronic structure docs #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ided meta_structure pass structure from blessed task when calling function for uniformity with other builders -> materilas, summary, magnetism
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 90.32% 90.19% -0.14%
==========================================
Files 147 147
Lines 14509 14508 -1
==========================================
- Hits 13105 13085 -20
- Misses 1404 1423 +19 ☔ View full report in Codecov by Sentry. |
tsmathis
force-pushed
the
elec-struct-mag-ordering
branch
from
1a17096 to
020486b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
determining the magnetic ordering for an electronic structure doc using the structures from either the bandstructure or dos task documents has been causing a discrepancy between the magnetic ordering determined by the magnetism builder, which uses the structure from the blessed task for a material to determine magnetic ordering.
callers of the
from_bsdosfunction should pass the blessed structure for the material explicitly through themeta_strucutrekwarg