Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary 'dielectric' field #1173

Merged
merged 1 commit into from
Jan 15, 2025
Merged

remove unnecessary 'dielectric' field #1173

merged 1 commit into from
Jan 15, 2025

Conversation

tsmathis
Copy link
Collaborator

dielectric was added as a field to Calculation in 8b23a06

frequency_dependent_dielectric is the appropriate field for this, so dielectric was a duplicate

covered by 'frequency_dependent_dielectric'
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (a294022) to head (49fc20f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   90.19%   90.19%   -0.01%     
==========================================
  Files         147      147              
  Lines       14508    14507       -1     
==========================================
- Hits        13085    13084       -1     
  Misses       1423     1423              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis assigned tsmathis and unassigned tsmathis Jan 15, 2025
@tsmathis tsmathis added the Core Any updates for Emmet-Core label Jan 15, 2025
@tsmathis tsmathis merged commit 8dfd66f into main Jan 15, 2025
8 checks passed
@tsmathis tsmathis deleted the drop-dielectric-field branch January 15, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Any updates for Emmet-Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants