Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve entry header #1643

Merged
merged 1 commit into from
Jan 1, 2024
Merged

feat: improve entry header #1643

merged 1 commit into from
Jan 1, 2024

Conversation

matthiasn
Copy link
Owner

@matthiasn matthiasn commented Jan 1, 2024

This PR improves the entry header spacing and ensures that the save button is visible even on the smallest screens by placing the icons in a horizontal scrollview.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0e1b082) 70.12% compared to head (87f5922) 70.12%.

Files Patch % Lines
...ets/journal/entry_details/entry_detail_header.dart 81.81% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1643   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files         269      269           
  Lines       10939    10943    +4     
=======================================
+ Hits         7671     7674    +3     
- Misses       3268     3269    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthiasn matthiasn merged commit 2a2a476 into main Jan 1, 2024
3 checks passed
@matthiasn matthiasn deleted the feat/wrap_icons branch January 1, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant